Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blade Rotational Velocity in ElastoDyn #453

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

jjonkman
Copy link
Collaborator

@jjonkman jjonkman commented May 29, 2020

Fixed a bug created from PR #391

Complete this sentence
THIS PULL REQUEST IS READY TO MERGE

Feature or improvement description
Fixed a bug created from PR #391

Related issue, if one exists
Fixed issue reported in #452

Impacted areas of the software
ElastoDyn motions used by AeroDyn

Additional supporting information
The rotational speed was accidentally doubled in the rotational velocity field of the ElastoDyn blade output mesh.

Test results, if applicable
Fixed issue reported in #452

@andrew-platt
Copy link
Collaborator

@jjonkman were the r-test baselines updated for this PR? I see we have several that fail:

The following tests FAILED:
	  7 - AOC_YFree_WTurb (Failed)
	  8 - AOC_YFix_WSt (Failed)
	 12 - WP_VSP_ECD (Failed)
	 13 - WP_VSP_WTurb (Failed)
	 18 - 5MW_OC3Mnpl_DLL_WTurb_WavesIrr (Failed)
	 24 - 5MW_OC4Semi_WSt_WavesWN (Failed)

@jjonkman
Copy link
Collaborator Author

jjonkman commented Jun 1, 2020

@andrew-platt -- No, the re-test baselines where not updated (I don't know how to do that or if I even have the ability to do that). I would expect differences for the WindPACT 1.5-MW baseline and NREL 5-MW baseline turbine r-test results, which have nonzero values of BlCrvAC and BlSwpAC. I would not expect differences in other r-tests.

@andrew-platt
Copy link
Collaborator

andrew-platt commented Jun 1, 2020

It is puzzling that 2 of 3 AOC turbine test cases fail (one that succeeds uses AD14, the failed ones use AD15). I'll look into the details on that one (we've noticed numerical issues in that one in the past).

@rafmudaf can we schedule a chat sometime to update the required r-test baselines?

@rafmudaf
Copy link
Collaborator

rafmudaf commented Jun 1, 2020

I've looked at the plots of the results and two failing AOC cases have no visible difference in the result.

@rafmudaf rafmudaf merged commit 0eec1b4 into OpenFAST:dev Jun 12, 2020
@rafmudaf rafmudaf mentioned this pull request Sep 11, 2020
@rafmudaf rafmudaf self-assigned this Oct 7, 2020
@jjonkman jjonkman deleted the b/ED_rotvel branch January 16, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants