ServoDyn and glue code bug fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bjonkman
commented
Sep 13, 2017
bjonkman
commented
- fixed problem with constant ElecPwr and GenTrq sent to Bladed DLL controller
- fixed error check that occurred before all information was obtained
This fixes issue with DLL controller getting constant values for GenTrq and ElecPwr, as reported in OpenFAST#40. If SrvD%y is ever used in another way (e.g., linearization), this method will have to be fixed. Note that it breaks the framework--but the Bladed DLL breaks the framework, too.
This check is done on a value output from the SrvD_Init() routine, but it occurred *before* calling SrvD_Init.
|
@rafaelmudafort , please comment on this pull request; what happens with the existing tests? |
ghost
mentioned this pull request
|
@michaelasprague on mac with gfortran, every test case passed the regression test |
jjonkman
approved these changes
Sep 14, 2017
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.