Unit test framework #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive around "PRIVATE"
look to the next commit for proper layout, this one is damaged due to too many local changes before issuing the commit
This reverts commit 07d2abe. # Conflicts: # modules-local/beamdyn/src/BeamDyn_Subs.f90
needs tests for cases where flag = 1 flag = 2 flag = 3
this does not yet correctly test the ExtractRelativeRotation subroutine. At least I dont think it does as its already failing, but it probably would have been evident if that subroutine were incorrect …
still need to test more branches - invalid rotation matrix - does the WM formulation have any boundaries?
because the resulting parameterized rotations may not be unique
subroutine removed in commit 92574d7
so future modules can be added easily
ghost
self-assigned this
ghost
requested review from
HaymanConsulting
previously requested changes
Sep 29, 2017
|
@ghaymanNREL ok I'll update that in the documentation pull request, #49 |
|
results from the regression test at commit 076466c |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds initial unit testing to BeamDyn. This is accomplished through pFUnit, an external xUnit-structured testing framework which is linked to OpenFAST as a
git submoduleand compiles with CMake. Currently, the following subroutines inBeamDyn.f90andBeamDyn_Subs.f90are testedDocumentation for unit testing is included in pull request #49. A template unit test is included in the
unit_testsdirectory, and all real tests reside in the module directory. For example, BeamDyn unit tests are stored inmodules-local/beamdyn/tests.This pull requests also improves the usage of the regression test system by adding a level of abstraction to the CTest configuration. More regression tests were added for BeamDyn as well.
Lastly, the CMake configuration was updated to set the install prefix to the more standard use case of
openfast/installrather than the defaultusr/localNote: this branch sits on top of the documentation work included in pull request #49 so all of those commits are currently listed here. After pull request #49 is merged, this should be resolved and only the feature/bd-instrumentation commits will be listed.