Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a compiler warning regarding the iso_fortran_env module #507

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix a compiler warning regarding the iso_fortran_env module #507

merged 1 commit into from
Jul 21, 2020

Conversation

rafmudaf
Copy link
Collaborator

Feature or improvement description
When compiling nwtclibs, the a recent addition that uses the iso_fortran_env module leads to a compiler warning regarding an incompatibility in another defined parameter in that module. This fix is limited to the compiler warning since the referenced module parameter was not used.

Related issue, if one exists
#504

Impacted areas of the software
NWTC_IO

@rafmudaf
Explicitly import a function from external module
419ad77 
This fixes a compiler warning that other imported symbols conflict with the numerical type definitions.
@rafmudaf rafmudaf self-assigned this Jul 20, 2020
@andrew-platt
Copy link
Collaborator

Good idea. I've been wondering about that warning.

@rafmudaf rafmudaf merged commit fdf2291 into OpenFAST:dev Jul 21, 2020
@rafmudaf rafmudaf deleted the iso_fortran_env_fix branch July 21, 2020 13:40
@sayerhs sayerhs mentioned this pull request Jul 22, 2020
Closed
bjonkman
bjonkman reviewed Jul 23, 2020
View reviewed changes
Copy link
Contributor

@bjonkman bjonkman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafmudaf: Isn't this going to reintroduce the problem that was fixed in #454? Old versions of the Intel compiler don't have the compiler_version function, so putting it in the ONLY list will cause issues there again. Maybe you need to add another #ifdef around the USE statement.

@andrew-platt
Copy link
Collaborator

I think we have a problem with old compilers. Nick just ran into it with Intel Fortran Compiler 17.0.2.187 and Visual Studio Community 2015.

@sayerhs
Copy link
Contributor

sayerhs commented Jul 28, 2020

@andrew-platt I believe this should fix issues with ISO_FORTRAN_ENV #512

@andrew-platt
Copy link
Collaborator

@sayerhs Yes that should fix it. I see that is still listed as a draft. Is there anything further required before we can merge it?

@andrew-platt andrew-platt mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjonkman bjonkman bjonkman left review comments

Assignees

@rafmudaf rafmudaf

Labels
Module: NWTC Lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rafmudaf @andrew-platt @sayerhs @bjonkman