Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTK folder and Vx sign for OLAF #590

Merged
merged 2 commits into from
Nov 17, 2020
Merged

VTK folder and Vx sign for OLAF #590

merged 2 commits into from
Nov 17, 2020

Conversation

ebranlard
Copy link
Contributor

Ready to merge

Feature or improvement description

  • Vx sign was wrong for aero outputs per node with OLAF
  • Folder fvw_vtk was not in the right location when openfast called from a different folder, no vtk files were produced

Impacted areas of the software
OLAF

@ebranlard ebranlard self-assigned this Nov 14, 2020
@andrew-platt
Copy link
Collaborator

andrew-platt commented Nov 17, 2020 •
edited
Loading

Note for our future selves:
For the Vx sign, this change now aligns the equation for the FVW output with that for the BEMT (code block above it, line 787). The signs used for Vx in the standard outputs match between FVW and BEMT, so this is expected here.

@rafmudaf rafmudaf merged commit ea253bf into OpenFAST:dev Nov 17, 2020
@rafmudaf rafmudaf mentioned this pull request Jan 13, 2021
Merged
@ebranlard ebranlard deleted the f/olafix branch May 26, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-platt andrew-platt andrew-platt approved these changes

Assignees

@ebranlard ebranlard

Labels
Module: AeroDyn Module: OLAF Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebranlard @andrew-platt @rafmudaf