Fix HydroDyn linearization matrix multiplication using unallocated arrays #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found in error message from OpenFAST#620
andrew-platt
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
HydroDyn was calling linearization routines for SS_Radiation and SS_Excitation without checking if those modules were ever initialized. This resulted in doing some matrix multiplications with unallocated matrices.
Related issue, if one exists
#620
Impacted areas of the software
Linearization with the HydroDyn module
Additional supporting information
The Windows Intel compiler seems to return an empty matrix, but some other compilers give a seg fault.
I haven't tested this, so someone who is more familiar with HydroDyn should review before merging.
Test results, if applicable
This should not change any results.