Disallow building with shared libraries and MSVC #699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My recent recent pull request #1010 might address this issue more directly. |
|
Closing this due to inactivity (and @rafmudaf said I can). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This pull requests disallows building with shared libraries while using the MSVC build tool.
Related issue, if one exists
#448
Impacted areas of the software
CMake on Windows with MSVC
Additional supporting information
Not tested!Test results, if applicable
Not tested!Update 5/12/2021: I've verified that with
BUILD_SHARED_LIBS=ON, the build system (tested with NMake) cannot find the required.libsthat should accompany a.dll. I've also verified that the error message in this pull request prevents the configuration when using MSVC andBUILD_SHARED_LIBS=ON. The MSVC CMake variable is True even when using all Intel compilers.