-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inflowWind C-bound interface and python wrapper #720
Conversation
# Conflicts: # .github/workflows/automated-dev-tests.yml # reg_tests/r-test
# Conflicts: # .github/actions/tests-module-inflowwind/action.yml # .github/workflows/automated-dev-tests.yml
Pythonize the InflowWind Python interface
Had to manually resolve a few files on GH. I ended up with some spurious empty lines in the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the difference between modules/inflowwind/src/IfW_C.f90
and modules/inflowwind/src/IfW_C_Binding.f90
? Is IfW_C
something left over from my pull request to @andrew-platt?
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #720 +/- ##
==========================================
+ Coverage 11.24% 11.27% +0.02%
==========================================
Files 207 211 +4
Lines 308325 309733 +1408
Branches 179941 180530 +589
==========================================
+ Hits 34661 34910 +249
- Misses 229958 230900 +942
- Partials 43706 43923 +217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Feature or improvement description
Ability to couple inflowWind to other c-based codes through a c-bound interface (specifically python). There is a python example driver code that illustrates how to use interface; the python-c library, and a c-bound wrapper for InflowWind.f90. This is not dependent on any other PRs.
Related issue, if one exists
None
Impacted areas of the software
inflowWind module only. uses NWTC IO library. Does not affect any existing functionality - only adds to the existing IFW code base.
Additional supporting information
Part of the ATLANTIS CCT2 project (collaborating with Sandia to merge HD, MD, and IFW into Julia-based OWENS)
Test results, if applicable
New regression tests for this IFW library, but existing tests should not be affected. New scripts have been demonstrated to work for WindTypes = 1, 2, 3.
Tasks