Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inflowWind C-bound interface and python wrapper #720

Merged
merged 69 commits into from
Sep 30, 2021

Conversation

nrmendoza
Copy link
Contributor

@nrmendoza nrmendoza commented Apr 16, 2021

Feature or improvement description
Ability to couple inflowWind to other c-based codes through a c-bound interface (specifically python). There is a python example driver code that illustrates how to use interface; the python-c library, and a c-bound wrapper for InflowWind.f90. This is not dependent on any other PRs.

Related issue, if one exists
None

Impacted areas of the software
inflowWind module only. uses NWTC IO library. Does not affect any existing functionality - only adds to the existing IFW code base.

Additional supporting information
Part of the ATLANTIS CCT2 project (collaborating with Sandia to merge HD, MD, and IFW into Julia-based OWENS)

Test results, if applicable
New regression tests for this IFW library, but existing tests should not be affected. New scripts have been demonstrated to work for WindTypes = 1, 2, 3.

Tasks

  • Update Visual Studio build system
  • Add regression test for inflowWind library interface
  • Port testing over to automated testing
  • cmake build for inflowWind library for Windows

@andrew-platt andrew-platt changed the base branch from main to dev June 8, 2021 21:23
@andrew-platt andrew-platt self-requested a review September 30, 2021 15:14
Copy link
Collaborator

@rafmudaf rafmudaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the difference between modules/inflowwind/src/IfW_C.f90 and modules/inflowwind/src/IfW_C_Binding.f90? Is IfW_C something left over from my pull request to @andrew-platt?

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 54.43038% with 36 lines in your changes missing coverage. Please review.

Project coverage is 11.27%. Comparing base (109002e) to head (7af1199).
Report is 3865 commits behind head on dev.

Files with missing lines Patch % Lines
modules/inflowwind/src/IfW_C_Binding.f90 55.26% 3 Missing and 31 partials ⚠️
modules/inflowwind/src/InflowWind_Subs.f90 0.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #720      +/-   ##
==========================================
+ Coverage   11.24%   11.27%   +0.02%     
==========================================
  Files         207      211       +4     
  Lines      308325   309733    +1408     
  Branches   179941   180530     +589     
==========================================
+ Hits        34661    34910     +249     
- Misses     229958   230900     +942     
- Partials    43706    43923     +217     
Flag Coverage Δ
regtests 11.16% <54.43%> (+0.04%) ⬆️
unittests 2.57% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants