Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features for unsteady aerodynamics modeling #729

Merged
merged 9 commits into from
Sep 20, 2021
Merged

Conversation

bjonkman
Copy link
Contributor

Feature or improvement description
This pull request includes the following new features:

  • UnsteadyAero can be turned off based on a node's radial location (as opposed to setting c_nalpha = 0 in individual airfoil files). Two new lines in the AeroDyn input file allow the user to specify the radial locations where unsteady aero will be on.
  • DBEMT_Mod = 3 is now available for time-marching simulations.
  • UAMod = 4 (HGM) is now available for time-marching simulations.
  • A new UAMod = 5 option is available. This model is based on HGM with one additional state.
  • Airfoil tables can now be constant (i.e., have fewer than 3 lines). UA is turned off for constant airfoil tables.
  • The UA parameters listed in the Airfoil files can now be calculated internally instead of user-specified. If any of the lines containing UA parameters are missing from the file, they get set by the code.

Related issue, if one exists
None

Impacted areas of the software
AeroDyn

Additional supporting information

  • I also added some more validity checks on AFI UA parameters

Test results, if applicable
These changes do not change any existing test cases. All changes to the input file are optional.

@andrew-platt
Copy link
Collaborator

@rafmudaf and @ebranlard
Should we merge this into the RC3.1 branch instead of dev? That way we can keep the current dev as the 3.0 release (hopefully releasing soon).

@ebranlard
Copy link
Contributor

As a small note, I've merged this branch with f/driver into my branch f/driver-ua, where I've added two other dynamic stall models (Oye and Boeing-Vertol), but it's fine by me if we do this in two pull requests. (Mine will change the polar input file, adding the relative thickness). We might just be both doing the merge with dev..

Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I really like the method of dealing with missing lines in input file parsing. I'll have to use it in other codes.

- The entries for the new `UAStartRad` and `UAEndRad` were added to the tables prior to release of v2.6.0 and 3.0.0 when this development branch was created.
Copy link
Contributor

@ebranlard ebranlard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is al good to me.

I've started using this branch in my branch f/driver-ua and have not seen any issue. We might need to do small adjustments on UAMod 4 and 5 in the future, but nothing that would prevent the merge now.

@ebranlard
Copy link
Contributor

ebranlard commented Aug 13, 2021

I've added some documentation here.

Which will become available when my branch get's merged. I believe it's fine to wait a couple of months for that.

@bjonkman
Copy link
Contributor Author

Since #729 was merged into #688, and #688 has subsequently been merged into OpenFAST/dev, the remaining changes here are minimal: some documentation of api changes, comments, and minor code cleanup.

@rafmudaf rafmudaf merged commit 3256c25 into OpenFAST:dev Sep 20, 2021
@bjonkman bjonkman deleted the f/UA branch January 18, 2022 18:10
@rafmudaf rafmudaf mentioned this pull request Mar 2, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants