Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for performance considerations with Fortran #740

Merged
merged 9 commits into from
Sep 20, 2021

Conversation

rafmudaf
Copy link
Collaborator

@rafmudaf rafmudaf commented May 4, 2021

Feature or improvement description
This pull request adds information regarding performance considerations in Fortran. The important content has been added, but the whole page requires a restructure to a more general format before merging.

Impacted areas of the software
Documentation

Additional supporting information
Live preview at https://raf-openfast.readthedocs.io/en/docs-performance/source/dev/performance.html#high-performance-programming-in-fortran

Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rafmudaf; this looks like valuable information. Please find must a few minor edits and comments in my review.

docs/source/dev/performance.rst Outdated Show resolved Hide resolved
docs/source/dev/performance.rst Outdated Show resolved Hide resolved
work in an effort to improve the time-to-solution performance for the most
computationally expensive use cases. This work is supported by Intel® through
its designation of NREL as an
A major focus of he OpenFAST team is performance-profiling and optimization
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to add in this section any of the profiling results you found regarding linearization within WEIS-OpenFAST? E.g., where are the computational bottlenecks in the linearization process--when computing the Jacobians of specific modules or when combining the Jacobians of each model into full-system-level Jacobians?

@rafmudaf rafmudaf force-pushed the docs/performance branch 2 times, most recently from d754c5d to 43d4cbd Compare June 23, 2021 18:30
@rafmudaf rafmudaf marked this pull request as ready for review June 30, 2021 22:02
Copy link
Collaborator

@jjonkman jjonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had reviewed this documentation in May and the recent items added look good to me. I approve the merge.

Thanks!

@rafmudaf rafmudaf merged commit 7267cdc into OpenFAST:dev Sep 20, 2021
@rafmudaf rafmudaf deleted the docs/performance branch September 20, 2021 18:15
@rafmudaf rafmudaf mentioned this pull request Mar 2, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants