[BugFix] segmentation fault in HD linearization #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error in logic for creating the state names for linearization.
jjonkman
approved these changes
Sep 23, 2021
|
Ideally we would also add a unit test for this. However, without any unit testing currently in HD and large structural changes coming with the revision of the Waves module, now isn't a great time to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Feature or improvement description
There was a logic error in creating the state names for linearization that caused an allocated array to be accessed. This only occurred during linearization when
ExctnMod==2andRdtnMod==0Related issue, if one exists
This fixes and closes #812.
Impacted areas of the software
HydroDyn linearization only.
Test results, if applicable
No tests currently use this combination of options during linearization of HD. No existing test results are affected.