Adds performance optimization to NWTC Lib and BeamDyn #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafmudaf: These optimizations in BeamDyn are covered in my EE-BeamDyn-OpenFAST-dev branch that you said you were going to review and merge (I calculate and store these constant values at initialization). There will be conflicts later if you accept the BD changes. |
|
@bjonkman Thank you for pointing out this merge conflict. This pull request is still under development, but I'll work on validating your changes in the meantime. |
|
@sinolonghai (@sayerhs ) can we close this given recent pull request (#114) and current Intel PCC work? |
|
@michaelasprague Yes, we can close this and submit a pull request after our IPCC work this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For beamdyn and modmesh changes: Some values are calculated repeatedly. The straight forward idea is to calculate it and store in a temporary variable and use it later.
For nwtc_num change: calculate the 3X3 matrix directly instead of doing matrix multiply.
This pull request is currently being modified.