Various improvements to SubDyn #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a rigid assembly that involves an interface joint, the joint selected as "leader" is always the interface node. There was a bug when the interface node was somehow futher down the list of joints as the other joints involved in the assembly. The list INodesID returned by RAElimination was correct, but after this function call, there was a need to directly address the other joints and change the "iNode" of the for loop so that it points to the leader Node. The variable "iNodeSel" was introduced to account for this.
…of python for SD regression tests
SD: add y3mesh handling to glue code
Codecov Report
@@ Coverage Diff @@
## dev #859 +/- ##
==========================================
+ Coverage 11.27% 11.28% +0.01%
==========================================
Files 211 211
Lines 309733 310488 +755
Branches 180530 181011 +481
==========================================
+ Hits 34910 35054 +144
- Misses 230900 231094 +194
- Partials 43923 44340 +417
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@andrew-platt @ebranlard It looks like this pull request included changes to the r-test commit, but that commit was not merged into the dev branch in the r-test repo. Is it safe to resolve that difference? |
|
Yes, additional tests were added to test the new features, it should safe to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is ready to merge.
Feature or improvement description
OutCBModesandOutFEMModes.Impacted areas of the software
SubDyn
Tests
New tests were added in the branch
f/SD-Loadsof ther-test. Including some tests for cable/rigid link/ rotational joints, from a comparison with Ansys.