-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AeroDyn cleanup #863
AeroDyn cleanup #863
Conversation
This type of syntax caused issues in some version of gfortran long ago: old-NWTC/NWTC_Library@976d9bd#diff-9cf80e40ecf0eacb20ef6f7042888d47defca409fb3c4bb7e972be47e93c2e6f Maybe this helps with OpenFAST#841?
also added `alt` keyword to figures to avoid warnings in VSCode previewer
Codecov Report
@@ Coverage Diff @@
## dev #863 +/- ##
=======================================
Coverage 11.28% 11.29%
=======================================
Files 211 211
Lines 310488 310557 +69
Branches 181011 181045 +34
=======================================
+ Hits 35054 35068 +14
- Misses 231363 231395 +32
- Partials 44071 44094 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Also, don't save variables for ProcessCom (initialize in declaration statement = SAVE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes looks good to me and might fix the issues with the AD reg tests failing at times. Thanks for doing that!
It all looks good to me, as well. Thanks for trying to track down the problem in #841. Let me know when you're ready to merge this pull request. |
You can merge it now. If I decide to dig into this some more, I'll open another PR. |
Thanks! |
This code
Related issue, if one exists
We should check if this helps with #841
Impacted areas of the software
docs, AeroDyn, AeroDyn driver