-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] incorrect init of aggregated output index arrays in FAST.Farm #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected: WkDfVxTND, WkDfVrTND, EddVisTND, EddAmbTND, EddShrTND Because of the call order, these were used prior to getting set. Only caught with running in debug in linux with -finit-integer=9999 flag
Should catch unalocated stuff a bit better with intel compiler
Codecov Report
@@ Coverage Diff @@
## dev #895 +/- ##
=======================================
Coverage 11.29% 11.29%
=======================================
Files 211 211
Lines 310557 310557
Branches 181045 181045
=======================================
Hits 35068 35068
Misses 231395 231395
Partials 44094 44094
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
andrew-platt
changed the title
[bugfix] incorrect order of aggregated output arrays in FAST.Farm
[bugfix] incorrect init of aggregated output arrays in FAST.Farm
Oct 26, 2021
andrew-platt
changed the title
[bugfix] incorrect init of aggregated output arrays in FAST.Farm
[bugfix] incorrect init of aggregated output index arrays in FAST.Farm
Oct 26, 2021
rafmudaf
reviewed
Oct 27, 2021
ebranlard
approved these changes
Oct 27, 2021
rafmudaf
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for merging.
Feature or improvement description
The arrays
WkDfVxTND, WkDfVrTND, EddVisTND, EddAmbTND, EddShrTND
are used to aggregate output channels inFAST_Farm_IO.f90. These had been used prior to actually getting set. So they may point to random garbage in memory.
This error could be caught when the
-finit-integer=9999.
flag was set on the debug gcc compile. Running the LESinflow or TSinflow case with this debug compile would trigger a segfault such asThis PR also includes additional flags for the intel compiler in debug mode build with cmake to set all reals and integers to large numbers or infinity, which should help catch this kind of issue in those cmake builds. VS builds have not been modified. Also a correction to a flag for the intel debug builds on linux/mac.
Impacted areas of the software
FAST.Farm
Additional supporting information
It doesn't appear than anyone has used these particular outputs, so it may not have affected anyone using FAST.Farm to date. If it did, they would potentially see an invalid channel, or garbage in that channel.
Test results, if applicable
No test results change.