-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD15: add nodal outputs for VUnd{xyz}i in global coords #917
AD15: add nodal outputs for VUnd{xyz}i in global coords #917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that these outputs looks reasonable. If possible, it would also make sense to add the equivalent outputs for the tower (TwNβVUndxi, etc.) and for the disturbed wind at blade nodes (BαNβVDisxi, etc.). Also, the list of AeroDyn outputs in the documentation should be changed accordingly: https://openfast.readthedocs.io/en/main/_images/ad_output_channel.pdf (I have the Word version of this).
I would add potentially the induced velocity as well :) |
Codecov Report
@@ Coverage Diff @@
## dev #917 +/- ##
==========================================
- Coverage 11.17% 11.17% -0.01%
==========================================
Files 211 211
Lines 310636 310648 +12
Branches 181308 181320 +12
==========================================
Hits 34722 34722
- Misses 231795 231807 +12
Partials 44119 44119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I would suggest to descope and merge this as it is :) |
Posted issue #1004 for the remaining items that were never completed. De-scoping this to what is thus far completed and merging (this backlog is ridiculous... mostly my fault though). |
This PR is NOT ready for merging (more channel requests)
Feature or improvement description
Three new nodal outputs are added to AD15 for the undisturbed wind velocity at each blade node:
VUndxi
Undisturbed wind velocity at blade node in global XVUndyi
Undisturbed wind velocity at blade node in global YVUndzi
Undisturbed wind velocity at blade node in global ZThese are particularly useful in checking the inflow into a blade on an OpenFAST turbine in a CFD coupled or FAST.Farm simulation. This feature was requested by @kshaler.
Example of data for the VUndxi channel for blade 1 (from the 5MW_Land_DLL_WTurb regression test case)
TODO