[BugFix] error handling in AWAE module #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready for merging
Feature or improvement description
The way the error handling was implemented in the AWAE module overwrote messages from early in the initialization and so they wouldn't be returned to the FARM code. Additionally, if a non-abort message occurred, the Init routine could return early before some array allocations occurred, which led to strange seg-faults.
In the FAST_Farm_Subs, the call to
Farm_InitOutputoverwrote any error messages coming out of the AWAE module, so any fatal error in AWAE would not be handled which could lead to segfaults.Related issue, if one exists
Possibly related to #784
Impacted areas of the software
Error handling in the AWAE module and FAST.Farm.
Test results, if applicable
No test results will be affected.