Reason is optional in HTTP2 (#1550)

OpenFeign · Dec 19, 2021 · 08fe6a3 · 08fe6a3
1 parent 6db8caa
commit 08fe6a3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/java11/src/main/java/feign/http2client/Http2Client.java b/java11/src/main/java/feign/http2client/Http2Client.java
@@ -129,7 +129,7 @@ protected Response toFeignResponse(Request request, HttpResponse<byte[]> httpRes
         .protocolVersion(enumForName(ProtocolVersion.class, httpResponse.version()))
         .body(new ByteArrayInputStream(httpResponse.body()),
             length.isPresent() ? (int) length.getAsLong() : null)
-        .reason(httpResponse.headers().firstValue("Reason-Phrase").orElse("OK"))
+        .reason(httpResponse.headers().firstValue("Reason-Phrase").orElse(null))
         .request(request)
         .status(httpResponse.statusCode())
         .headers(castMapCollectType(httpResponse.headers().map()))

diff --git a/java11/src/test/java/feign/http2client/test/Http2ClientTest.java b/java11/src/test/java/feign/http2client/test/Http2ClientTest.java
@@ -1,5 +1,5 @@
 /**
- * Copyright 2012-2020 The Feign Authors
+ * Copyright 2012-2021 The Feign Authors
  *
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
@@ -67,6 +67,20 @@ public void noResponseBodyForPatch() {
   @Override
   @Test
   public void reasonPhraseIsOptional() throws IOException, InterruptedException {
+    server.enqueue(new MockResponse()
+        .setStatus("HTTP/1.1 " + 200));
+
+    final AbstractClientTest.TestInterface api = newBuilder()
+        .target(AbstractClientTest.TestInterface.class, "http://localhost:" + server.getPort());
+
+    final Response response = api.post("foo");
+
+    assertThat(response.status()).isEqualTo(200);
+    assertThat(response.reason()).isNull();
+  }
+
+  @Test
+  public void reasonPhraseInHeader() throws IOException, InterruptedException {
     server.enqueue(new MockResponse()
         .addHeader("Reason-Phrase", "There is A reason")
         .setStatus("HTTP/1.1 " + 200));
@@ -80,7 +94,6 @@ public void reasonPhraseIsOptional() throws IOException, InterruptedException {
     assertThat(response.reason()).isEqualTo("There is A reason");
   }
 
-
   @Override
   @Test
   public void testVeryLongResponseNullLength() {