simplify valuesOrEmpty (#938)

there are 3 lookups in the map, and one should be sufficient
OpenFeign · May 13, 2019 · a269e95 · a269e95
1 parent 01b9560
commit a269e95
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/core/src/main/java/feign/Util.java b/core/src/main/java/feign/Util.java
@@ -191,7 +191,8 @@ public static <T> T[] toArray(Iterable<? extends T> iterable, Class<T> type) {
    * Returns an unmodifiable collection which may be empty, but is never null.
    */
   public static <T> Collection<T> valuesOrEmpty(Map<String, Collection<T>> map, String key) {
-    return map.containsKey(key) && map.get(key) != null ? map.get(key) : Collections.<T>emptyList();
+    Collection<T> values = map.get(key);
+    return values != null ? values : Collections.emptyList();
   }
 
   public static void ensureClosed(Closeable closeable) {