Skip to content

Commit

Permalink
Copy default config if present before per request timeouts setting in (
Browse files Browse the repository at this point in the history
…#734)

ApacheHttpClient
  • Loading branch information
yfei-z authored and velo committed Jul 6, 2018
1 parent 248bb9a commit fa30e55
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.apache.http.StatusLine;
import org.apache.http.client.HttpClient;
import org.apache.http.client.config.RequestConfig;
import org.apache.http.client.methods.Configurable;
import org.apache.http.client.methods.HttpUriRequest;
import org.apache.http.client.methods.RequestBuilder;
import org.apache.http.client.utils.URIBuilder;
Expand Down Expand Up @@ -89,8 +90,7 @@ HttpUriRequest toHttpUriRequest(Request request, Request.Options options)
RequestBuilder requestBuilder = RequestBuilder.create(request.method());

// per request timeouts
RequestConfig requestConfig = RequestConfig
.custom()
RequestConfig requestConfig = (client instanceof Configurable ? RequestConfig.copy(((Configurable) client).getConfig()) : RequestConfig.custom())
.setConnectTimeout(options.connectTimeoutMillis())
.setSocketTimeout(options.readTimeoutMillis())
.build();
Expand Down

0 comments on commit fa30e55

Please sign in to comment.