Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeteredClient.execute(), The counter indicator increases by 2 each time #1480

Closed
flysun3344 opened this issue Aug 11, 2021 · 2 comments · Fixed by #1548
Closed

MeteredClient.execute(), The counter indicator increases by 2 each time #1480

flysun3344 opened this issue Aug 11, 2021 · 2 comments · Fixed by #1548

Comments

@flysun3344
Copy link

企业微信截图_02a28ec3-5b59-4210-9dbe-a472c0ed07ae

"sample.stop(timer)" in the finally code block should be placed in "if(time == null)"

@flysun3344
Copy link
Author

The above problem is in feign-micrometer version 11.6

@vitalijr2
Copy link
Collaborator

No, it isn't.

If the sample.stop(timer) will be placed in this block we stop to call this method for any exception as there aren't any case when timer is null in finally block:

Of course we can leave if (timer == null) to work with Error and Throwable.
But here should be only one call of thestop: we should remove it from main block try-catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants