Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micrometer MeteredDecoder records timer twice in happy path #1553

Closed
ErikKringen opened this issue Dec 20, 2021 · 2 comments · Fixed by #1554
Closed

Micrometer MeteredDecoder records timer twice in happy path #1553

ErikKringen opened this issue Dec 20, 2021 · 2 comments · Fixed by #1554

Comments

@ErikKringen
Copy link

Similar to #1480.

The sample.stop call on L65 should be removed and let the one if the finally block handle all paths

feign/micrometer/src/main/java/feign/micrometer/MeteredDecoder.java

Line 65 in 1f7ca4c

sample.stop(timer);

@vitalijr2
Copy link
Collaborator

There is the fix #1548.
It has not been released yet.

@ErikKringen
Copy link
Author

There is the fix #1548.
It has not been released yet.

#1548 Address MeteredClient only, this is in MeteredDecoder which has the same issue

@vitalijr2 vitalijr2 mentioned this issue Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MeteredDecoder records timer once in happy path vitalijr2/feign
2 participants
@vitalijr2 @ErikKringen