Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployments to Sonatype are consistently failing #2047

Closed
kdavisk6 opened this issue May 15, 2023 · 1 comment · Fixed by #2048
Closed

Deployments to Sonatype are consistently failing #2047

kdavisk6 opened this issue May 15, 2023 · 1 comment · Fixed by #2048

Comments

@kdavisk6
Copy link
Member

See 6697

I fixed the singing key issue as it had expired. However, we now see the following:

[ERROR] Failed to execute goal org.moditect:moditect-maven-plugin:1.0.0.Final:add-module-info (add-module-infos) on project feign-okhttp: Execution add-module-infos of goal org.moditect:moditect-maven-plugin:1.0.0.Final:add-module-info failed: duplicate element: okio -> [Help 1]

This appears to be something recent, I'm not sure how to fix this, but until we do, no deployments will go to OSS/Central
kdavisk6 added a commit to kdavisk6/feign that referenced this issue May 16, 2023
@kdavisk6
OpenFeignGH-2047: Exclude okio from module info
1c54ec9 
This change updates the module info generation for feign-okhttp, excluding `okio` from the tree since it does not conform to JPMS standards and results in duplicate module entries.  See square/okhttp#4184 for information from Square about it.

Additional Changes
---
* Ensure Wikipedia with Spring Boot only uses JDK 17
* Renamed Wikipedia with Spring Boot to be unique
@kdavisk6 kdavisk6 mentioned this issue May 16, 2023
Merged
kdavisk6 added a commit that referenced this issue May 16, 2023
@kdavisk6
GH-2047: Exclude okio from module info (#2048)
fda7329 
This change updates the module info generation for feign-okhttp, excluding `okio` from the tree since it does not conform to JPMS standards and results in duplicate module entries.  See square/okhttp#4184 for information from Square about it.

Additional Changes
---
* Ensure Wikipedia with Spring Boot only uses JDK 17
* Renamed Wikipedia with Spring Boot to be unique
@kdavisk6
Copy link
Member Author

Snapshot deployments are now working again.

velo pushed a commit that referenced this issue Oct 7, 2024
@kdavisk6
GH-2047: Exclude okio from module info (#2048)
3d60df5 
This change updates the module info generation for feign-okhttp, excluding `okio` from the tree since it does not conform to JPMS standards and results in duplicate module entries.  See square/okhttp#4184 for information from Square about it.

Additional Changes
---
* Ensure Wikipedia with Spring Boot only uses JDK 17
* Renamed Wikipedia with Spring Boot to be unique
velo pushed a commit that referenced this issue Oct 8, 2024
@kdavisk6
GH-2047: Exclude okio from module info (#2048)
bc6dbd1 
This change updates the module info generation for feign-okhttp, excluding `okio` from the tree since it does not conform to JPMS standards and results in duplicate module entries.  See square/okhttp#4184 for information from Square about it.

Additional Changes
---
* Ensure Wikipedia with Spring Boot only uses JDK 17
* Renamed Wikipedia with Spring Boot to be unique
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-2047: Exclude okio from module info kdavisk6/feign
1 participant
@kdavisk6