Building FeignException can throw llegalCharsetNameException #2540
Labels
good first issue
Issues that are good for first time contributors to tackle
help wanted
Issues we need help with tackling
Comments
|
Sounds like you have a good handle on the issue, I recommend submitting a pull request. |
kdavisk6
added
help wanted
kubav182
pushed a commit
to kubav182/feign
that referenced
this issue
Sep 11, 2024
FeignException does not throw exception during extracting response charset now. These content types are all valid: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8"
kubav182
pushed a commit
to kubav182/feign
that referenced
this issue
Sep 11, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes OpenFeign#2540
kubav182
pushed a commit
to kubav182/feign
that referenced
this issue
Sep 12, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes OpenFeign#2540
kubav182
pushed a commit
to kubav182/feign
that referenced
this issue
Sep 12, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes OpenFeign#2540
velo
pushed a commit
that referenced
this issue
Sep 16, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes #2540 Co-authored-by: Jakub Venglar <venglar@rixo.cz>
velo
pushed a commit
that referenced
this issue
Oct 7, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes #2540 Co-authored-by: Jakub Venglar <venglar@rixo.cz>
velo
pushed a commit
that referenced
this issue
Oct 8, 2024
While building FeignException, ignore quotes in regexp, ignore case and catch IllegalCharsetNameException to be sure it does not raise in other cases. These content types are all valid and results in utf-8: text/html;charset=utf-8 text/html;charset=UTF-8 Text/HTML;Charset="utf-8" text/html; charset="utf-8" Fixes #2540 Co-authored-by: Jakub Venglar <venglar@rixo.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WHERE:
In this class https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/FeignException.java is piece of code:
WHATS WRONG:
Some external apis can send header Content-Type: text/xml;charset="utf-8" in response. Problem is with quotes.
Method Charset.isSupported throws exception when quotes are part of input string as it checks valid characters.
So building FeignException throws exception in this case.
EXPECTED BEHAVIOUR:
IF statement does not throw exception. It returns true or null in this case. We can't change external api and preprocess response headers is impossible as they are unmodifiable.
SOLUTION:
A. If you want to return true just sanitize String input group and remove for example quotes. Or change regexp to extract it without quotes.
group.replaceAll("\"", "");B. Catch llegalCharsetNameException and return null from IF statement.
The text was updated successfully, but these errors were encountered: