Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url field in FeignException #845

Closed
maxvetrenko opened this issue Nov 20, 2018 · 1 comment · Fixed by #1039
Closed

Url field in FeignException #845

maxvetrenko opened this issue Nov 20, 2018 · 1 comment · Fixed by #1039
Labels
proposal Proposed Specification or API change waiting for votes Enhancements or changes proposed that need more support before consideration

Comments

@maxvetrenko
Copy link

When RetryableException was caused we have information about url only in exception message. I think it will be useful to have url like an exception field.

Some argumentation. Suppose we have several feign clients with same api type but different url. When RetryableException was caused we have information about unhealthy url only in exception message. Url like field will give more possibilities to handle error more correctly
@kdavisk6 kdavisk6 added enhancement For recommending new capabilities question General usage or 'how-to' questions labels Dec 1, 2018
@kdavisk6
Copy link
Member

kdavisk6 commented Dec 5, 2018

I think what we may want to do is what we've done elsewhere and store the original request as part of FeignException. Would this work for you?

@kdavisk6 kdavisk6 mentioned this issue Dec 5, 2018
Closed
@kdavisk6 kdavisk6 added waiting for votes Enhancements or changes proposed that need more support before consideration proposal Proposed Specification or API change and removed question General usage or 'how-to' questions enhancement For recommending new capabilities labels May 28, 2019
@finnetrolle finnetrolle mentioned this issue Aug 19, 2019
Merged
kdavisk6 pushed a commit that referenced this issue Aug 26, 2019
@finnetrolle @kdavisk6
GH-845: Add Request to Feign Exception (#1039)
d3665e4 
Fixes #845 

This change allows Feign Exceptions to be created with the original request as an optional parameter.

Changes include:
* Request field added to FeignException
* New constructors are defended from null in request argument
* Tests to check null instead of request, null message updated
velo pushed a commit that referenced this issue Oct 7, 2024
@finnetrolle @kdavisk6
GH-845: Add Request to Feign Exception (#1039)
d7db804 
Fixes #845 

This change allows Feign Exceptions to be created with the original request as an optional parameter.

Changes include:
* Request field added to FeignException
* New constructors are defended from null in request argument
* Tests to check null instead of request, null message updated
velo pushed a commit that referenced this issue Oct 8, 2024
@finnetrolle @kdavisk6
GH-845: Add Request to Feign Exception (#1039)
38bd694 
Fixes #845 

This change allows Feign Exceptions to be created with the original request as an optional parameter.

Changes include:
* Request field added to FeignException
* New constructors are defended from null in request argument
* Tests to check null instead of request, null message updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal Proposed Specification or API change waiting for votes Enhancements or changes proposed that need more support before consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Request field added to FeignException
2 participants
@maxvetrenko @kdavisk6