Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Release Process with Travis #963

Closed
kdavisk6 opened this issue May 9, 2019 · 1 comment · Fixed by #962
Closed

Improve Release Process with Travis #963

kdavisk6 opened this issue May 9, 2019 · 1 comment · Fixed by #962
Labels
proposal Proposed Specification or API change

Comments

@kdavisk6
Copy link
Member

kdavisk6 commented May 9, 2019

Releasing feign, while simple, can be troublesome due to the updates we've made recently in an attempt to provide initial support for JDK 11.

The current release process assumes a single job in travis and our changes to support JDK 11 split each build into 2 jobs, one for JDK 8 and other for JDK 11. This poses an issue when releasing as the build process will attempt to tag and release twice. To avoid this, we, the maintainers, temporarily disable the JDK 11 builds, push the release, then re-enable them again after the release is complete.

In addition, the release process requires a temporary tag to trigger the process. This results in two tags for each release. We typically delete the trigger tag afterwards to reduce confusion.

I feel this should not be necessary and that releasing should be "easy". To make this "easier", I'm proposing the following changes:

  1. Take advantage for Travis' Conditional Build Stages to separate the test stage from the deploy stage.
  2. Update this new deploy stage to run only when a tag is created, removing the need to create a temporary release tag.
  3. Provide an automated way of creating the release tag, to reduce errors.

I've create a PR #962 that demonstrates these changes. Looking forward to your feedback.

@kdavisk6 kdavisk6 added the proposal Proposed Specification or API change label May 9, 2019
@velo
Copy link
Member

velo commented May 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposed Specification or API change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants