Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-801: Adding support for JDK Proxy #1045

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

kdavisk6
Copy link
Member

Fixes #801

Adding a Proxied client implementation that extends the Default
client allowing for a JDK Proxy, along with explict credential support.

Fixes OpenFeign#801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
@kdavisk6 kdavisk6 force-pushed the gh-801-proxy-client branch from db792ed to 823529f Compare August 23, 2019 14:43
@kdavisk6
Copy link
Member Author

@herrhilmi

I've updated your pull request and created one here. This contains your changes plus our suggestions.

@kdavisk6 kdavisk6 requested a review from velo August 23, 2019 14:52
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdavisk6 kdavisk6 merged commit 91e9882 into OpenFeign:master Aug 26, 2019
@kdavisk6 kdavisk6 deleted the gh-801-proxy-client branch August 29, 2019 15:34
velo pushed a commit that referenced this pull request Oct 7, 2024
Fixes #801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
velo pushed a commit that referenced this pull request Oct 8, 2024
Fixes #801

Adding a `Proxied` client implementation that extends the `Default`
client allowing for a JDK Proxy, along with explict credential support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxied and non-proxied Feign client on the same jvm
2 participants