Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Google HTTP Client support #1057

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Add Google HTTP Client support #1057

merged 2 commits into from
Aug 30, 2019

Conversation

blakesmith
Copy link
Contributor

Per the discussion in: #1053, this PR adds the Google HTTP Client module into feign.

The client passes the standard AbstractClientTest suite:

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running feign.googleclient.GoogleHttpClientTest
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.436 s - in feign.googleclient.GoogleHttpClientTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0

@blakesmith blakesmith mentioned this pull request Aug 29, 2019
Closed
velo
velo requested changes Aug 30, 2019
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change and some docs

googleclient/pom.xml Outdated Show resolved Hide resolved
googleclient/README.md Outdated Show resolved Hide resolved
googleclient/src/main/java/feign/googleclient/GoogleHttpClient.java Outdated Show resolved Hide resolved
@kdavisk6 kdavisk6 added enhancement For recommending new capabilities feedback provided Feedback has been provided to the author labels Aug 30, 2019
@blakesmith
Copy link
Contributor Author

@velo Updated with your feedback, thanks for taking a look!

@kdavisk6
Copy link
Member

@blakesmith

I've approved this change and marked it ready to merge. If there are no additional comments, I'll merge this change later today. Since this is a new module, I will also publish a new release to Maven Central (10.4) once this is merged.

@kdavisk6 kdavisk6 added ready to merge Will be merged if no other member ask for changes and removed feedback provided Feedback has been provided to the author labels Aug 30, 2019
@blakesmith
Copy link
Contributor Author

@kdavisk6 Sounds good, and thanks for the help!

@kdavisk6
Copy link
Member

@blakesmith

And thank you for putting the time and effort into add this feature.

@kdavisk6 kdavisk6 merged commit 6dbc22e into OpenFeign:master Aug 30, 2019
@kdavisk6
Copy link
Member

@blakesmith

This is now live on Maven Central in Feign 10.4.0

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
velo pushed a commit that referenced this pull request Oct 7, 2024
@blakesmith @kdavisk6
GH-1053: Add Google HTTP Client support (#1057)
191b114 
Fixes #1053 

Add Google HTTP Client submodule
velo pushed a commit that referenced this pull request Oct 8, 2024
@blakesmith @kdavisk6
GH-1053: Add Google HTTP Client support (#1057)
52f87a5 
Fixes #1053 

Add Google HTTP Client submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdavisk6 kdavisk6 kdavisk6 approved these changes

@velo velo velo approved these changes

Assignees
No one assigned
Labels
enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blakesmith @kdavisk6 @velo