JDK 11 HttpClient async implement for AsyncFeign. #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I run |
…cfeign-java11-impl � Conflicts: � java11/src/main/java/feign/http2client/Http2Client.java
# Conflicts: # java11/src/main/java/feign/http2client/Http2Client.java
|
@UzimakiNaruto Looks like you have some formatting issues. Please run |
kdavisk6
added
the
waiting for feedback
|
@kdavisk6 Hi, I fixed the format. the check looks fine now. Thanks. |
velo
approved these changes
Jul 23, 2021
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* java11 async http client for AsyncFeign * java 11 httpclient not allow some header * add unit test * add license * remove unused annotation * Merge branch 'master' of https://github.com/OpenFeign/feign into asyncfeign-java11-impl � Conflicts: � java11/src/main/java/feign/http2client/Http2Client.java * port connectionTimeout feature of Http2Client to AsyncHttpClient * fix format * Combined Sync and Async clients into a single class Co-authored-by: UzimakiNaruto <ff578505546@qq.com> Co-authored-by: Kevin Davis <kdavisk6@gmail.com> Co-authored-by: Marvin Froeder <velo@users.noreply.github.com> Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* java11 async http client for AsyncFeign * java 11 httpclient not allow some header * add unit test * add license * remove unused annotation * Merge branch 'master' of https://github.com/OpenFeign/feign into asyncfeign-java11-impl � Conflicts: � java11/src/main/java/feign/http2client/Http2Client.java * port connectionTimeout feature of Http2Client to AsyncHttpClient * fix format * Combined Sync and Async clients into a single class Co-authored-by: UzimakiNaruto <ff578505546@qq.com> Co-authored-by: Kevin Davis <kdavisk6@gmail.com> Co-authored-by: Marvin Froeder <velo@users.noreply.github.com> Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case i was copy from AsyncApacheHttp5ClientTest and some code was changed ..
thanks.