Fixed flaky tests due to class.getMethods
#1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Oct 26, 2021
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Fixed flaky tests due to `class.getMethod` * Simplify Comparator code
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Fixed flaky tests due to `class.getMethod` * Simplify Comparator code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some flaky tests in
feign.TypesResolveReturnTypeTestthat are caused by using theclass.getMethodsmethod.According to Java docs:
This means that future changes in Java may change the order of the returned list, and cause tests failures in this file. I created a
getMethodsmethod to sort the result fromclass.getMethodsusing alphabetical order with combos of the method name and return type name.Then I just replaced the
class.getMethodswith the newgetMethodsmethod, and updated some of the indexs in related tests to ensure deterministic order and behavior in the future.