Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate QueryMap.encode, remove processing of the "encode" parameter #1551

Merged
merged 10 commits into from
Mar 20, 2022

Conversation

vitalijr2
Copy link
Collaborator

@vitalijr2 vitalijr2 commented Dec 20, 2021

Was mentioned in #1475:

  • as Param.encode is deprecated,
  • as we have two encode steps:
  • as UriUtils.encode does not encode string if it is already encoded.

I propose:

  • encode both names and values in ReflectiveFeign, leave another names' encoding in CollectionFormat as it is not conflict with first. see UriUtils.isEncoded
  • mark QueryMap.encode as deprecated too.

@velo velo merged commit 55b35f7 into OpenFeign:master Mar 20, 2022
velo added a commit that referenced this pull request Oct 7, 2024
#1551)

Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo added a commit that referenced this pull request Oct 8, 2024
#1551)

Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants