Stream decoder optimize #1590
Merged
Stream decoder optimize #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
requested changes
Mar 7, 2022
velo
requested changes
Mar 8, 2022
velo
approved these changes
Mar 17, 2022
…amDecoderOptimize
mroccyen
force-pushed
the
StreamDecoderOptimize
branch
from
ae36e27 to
3378e13
Compare
…amDecoderOptimize # Conflicts: # core/src/test/java/feign/stream/StreamDecoderTest.java
…amDecoderOptimize # Conflicts: # core/src/test/java/feign/stream/StreamDecoderTest.java
|
Thank you for updating. If you could please add a section to the README with some documentation, this PR looks ready to be merged. |
kdavisk6
previously requested changes
Mar 25, 2022
velo
approved these changes
Mar 25, 2022
I've already added it. |
velo
reviewed
Apr 29, 2022
| this.iteratorDecoder = iteratorDecoder; | ||
| this.delegateDecoder = delegateDecoder != null |
There was a problem hiding this comment.
this.delegateDecoder = Optional.ofNullable(delegateDecoder);
velo
approved these changes
Apr 29, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add some example * Optimize StreamDecoder * add a section of README for stream decoder * Update StreamDecoder.java Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add license header * Optimize StreamDecoder * Optimize StreamDecoder * Optimize StreamDecoder * add some example * Optimize StreamDecoder * add a section of README for stream decoder * Update StreamDecoder.java Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following optimizations: