Add async behavior to OkHttpClient #1629
Conversation
Removes the need to share code in an abstract class.
| import feign.Client; | ||
| import feign.Request.HttpMethod; | ||
| import feign.Request.ProtocolVersion; | ||
| import okhttp3.*; | ||
| import org.jetbrains.annotations.NotNull; |
There was a problem hiding this comment.
not sure what is that, but please remove it
There was a problem hiding this comment.
Some annotations IntelliJ added when generating the interface implementation. I removed it :)
|
@velo What is the release process for Feign ? Will this change trigger a new release or is there a planned date to release that and other improvements ? |
releases are pretty much mood driven =) Every time an exciting thing is merged, it triggers me to make a release. I will create one for this |
|
Hey @velo , I noticed there is still no release. Don't want to harass you but that would really be great if you could cut one :) |
|
sorry, was trying to squeeze Async capabilities into this release |
|
release process triggered, next hour or so should see the binaries on central |
* Add AsyncOkHttpClient implementation * Make OkHttpClient implement both Client and AsyncClient Removes the need to share code in an abstract class. * Update mindmap * Update CHANGELOG.md * Remove jetbrains specific annotations
* Add AsyncOkHttpClient implementation * Make OkHttpClient implement both Client and AsyncClient Removes the need to share code in an abstract class. * Update mindmap * Update CHANGELOG.md * Remove jetbrains specific annotations
Make
OkHttpClientimplementAsyncClient.Changes
Modified
OkHttpClientimplementAsyncClient. The implementation does not handlerequestContext.Added
OkHttpClientAsyncTest: Test class is a copypasta of other async client tests, please advise for a better solution.