Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative ResponseInterceptor attempt #1634

Merged
merged 9 commits into from
Jun 23, 2022

Conversation

velo
Copy link
Member

@velo velo commented Jun 21, 2022

No description provided.

@velo velo requested a review from vitalijr2 June 22, 2022 22:41
@velo velo added the ready to merge Will be merged if no other member ask for changes label Jun 22, 2022
@velo velo merged commit a259a72 into OpenFeign:master Jun 23, 2022
@velo velo deleted the ResponseInterceptor branch June 23, 2022 00:58
@fanthos
Copy link

fanthos commented Jul 5, 2022

Seems that I can have only single ResponseInterceptor for Feign client. It would be great if the ResponseInterceptor could be chained.

@velo
Copy link
Member Author

velo commented Jul 5, 2022

Seems that I can have only single ResponseInterceptor for Feign client. It would be great if the ResponseInterceptor could be chained.

that indeed would be a nice improvement, feel free to start a PR for it

velo added a commit that referenced this pull request Oct 7, 2024
* add ResponseInterceptor support #1126

* Add the license header.

Add the license header.

Co-authored-by: Dewald de Jager <DewaldDeJager@users.noreply.github.com>

* small fix for license header

* fix format issue

* combine before and after method to one aroundDecode method

* Change ResponseInterceptor to use InvocationContext

Co-authored-by: Fei,Yanke <yanke.fei@mosi-tech.com>
Co-authored-by: feiyanke <feiyanke@126.com>
Co-authored-by: Dewald de Jager <DewaldDeJager@users.noreply.github.com>
velo added a commit that referenced this pull request Oct 8, 2024
* add ResponseInterceptor support #1126

* Add the license header.

Add the license header.

Co-authored-by: Dewald de Jager <DewaldDeJager@users.noreply.github.com>

* small fix for license header

* fix format issue

* combine before and after method to one aroundDecode method

* Change ResponseInterceptor to use InvocationContext

Co-authored-by: Fei,Yanke <yanke.fei@mosi-tech.com>
Co-authored-by: feiyanke <feiyanke@126.com>
Co-authored-by: Dewald de Jager <DewaldDeJager@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Will be merged if no other member ask for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants