Only allow a single content-type header to be applied while using googlehttpclient #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Sep 7, 2022
|
@velo Thank you so much for merging in this pr! I was wondering when I can expect to see a build with this bug fix and if there's anything I can do to help. Thanks! |
1 task
velo
added a commit
that referenced
this pull request
Oct 7, 2024
…glehttpclient (#1737) * Only allow a single content-type header to be applied while using google client * Run code formatter * Run formatter again via cmd line Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
…glehttpclient (#1737) * Only allow a single content-type header to be applied while using google client * Run code formatter * Run formatter again via cmd line Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Fixed issue where multiple content-type headers were being added to the request while using googlehttpclient.
Research
Multiple
Content-Typeheaders goes against the specImplementation Summary
Ignore
Content-Typefrom being set on the request because it'll be added via ByteArrayContent