Refactor async feign #1755
Merged
Refactor async feign #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
2-refactor-async-feign
branch
from
11413f0 to
81646ac
Compare
velo
approved these changes
Sep 19, 2022
| @@ -44,10 +45,17 @@ | |||
| * be done (for example, creating and submitting a task to an {@link ExecutorService}). | |||
| */ | |||
| @Experimental | |||
| public abstract class AsyncFeign<C> extends Feign { | |||
There was a problem hiding this comment.
Loved this.
I was hating myself for having asyncBuilder but couldn't take the time to fix it, amazing job, thanks
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Add MethodInfoResolver to customize MethodInfo creation logic * Add methodInfoResolver setter to AsyncBuilder * Refactor CoroutineFeign to use AsyncFeignBuilder instead of FeignBuilder * Deprecate CoroutineFeign.coBuilder * Change AsyncFeign to not inherit Feign * Deprecate AsyncFeign.asyncBuilder * Refactor AsyncBuilder to build Feign directly Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Add MethodInfoResolver to customize MethodInfo creation logic * Add methodInfoResolver setter to AsyncBuilder * Refactor CoroutineFeign to use AsyncFeignBuilder instead of FeignBuilder * Deprecate CoroutineFeign.coBuilder * Change AsyncFeign to not inherit Feign * Deprecate AsyncFeign.asyncBuilder * Refactor AsyncBuilder to build Feign directly Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #1754 PR commits
If you want to see the final result, see PR #1757
TODO