[GH-1464] Add appendHeader that supports Literals #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new `appendHeader` internal method to `RequestTemplate` allowing for already resolved headers to be added to the resolved `RequestTemplate` preventing duplicate expression processing by using another new method `HeaderTemplate.literal` and `HeaderTemplate.appendLiteral` respectively. I chose this route as it isolates the change to be applied only after the original `HeaderTemplate` has been resolved. While it does expose new public `HeaderTemplate` APIs, I feel that is an OK trade off, allowing a new escape-hatch for situations where URI template processing is not acceptable for Header values.
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
This change adds a new `appendHeader` internal method to `RequestTemplate` allowing for already resolved headers to be added to the resolved `RequestTemplate` preventing duplicate expression processing by using another new method `HeaderTemplate.literal` and `HeaderTemplate.appendLiteral` respectively. I chose this route as it isolates the change to be applied only after the original `HeaderTemplate` has been resolved. While it does expose new public `HeaderTemplate` APIs, I feel that is an OK trade off, allowing a new escape-hatch for situations where URI template processing is not acceptable for Header values.
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
This change adds a new `appendHeader` internal method to `RequestTemplate` allowing for already resolved headers to be added to the resolved `RequestTemplate` preventing duplicate expression processing by using another new method `HeaderTemplate.literal` and `HeaderTemplate.appendLiteral` respectively. I chose this route as it isolates the change to be applied only after the original `HeaderTemplate` has been resolved. While it does expose new public `HeaderTemplate` APIs, I feel that is an OK trade off, allowing a new escape-hatch for situations where URI template processing is not acceptable for Header values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new
appendHeaderinternal method toRequestTemplateallowing for already resolved headers to be added to the resolvedRequestTemplatepreventing duplicate expression processing by using another new methodHeaderTemplate.literalandHeaderTemplate.appendLiteralrespectively.I chose this route as it isolates the change to be applied only after the original
HeaderTemplatehas been resolved. While it does expose new publicHeaderTemplateAPIs, I feel that is an OK trade off, allowing a new escape-hatch for situations where URI template processing is not acceptable for Header values.