Eliminates unnecessary overhead #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
refactor-ResponseHander
branch
6 times, most recently
from
a57a3a9 to
1d6d083
Compare
wplong11
force-pushed
the
refactor-ResponseHander
branch
2 times, most recently
from
9aa5dc0 to
84becff
Compare
wplong11
force-pushed
the
refactor-ResponseHander
branch
from
d5b7357 to
253a47c
Compare
wplong11
force-pushed
the
refactor-ResponseHander
branch
from
e4d7269 to
4304656
Compare
Eliminates unnecessary overhead caused by CompletableFutre on synchronous operation.
wplong11
force-pushed
the
refactor-ResponseHander
branch
from
4086022 to
4d1d7bf
Compare
|
@velo I pushed the modified commit, but Circle CI doesn't seem to be newly triggered |
velo
approved these changes
Oct 11, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Refactor AsyncResponseHandler * Extract ResponseHandler from AsyncResponseHandler * Use ResponseHandler on SynchronousMethodHandler Eliminates unnecessary overhead caused by CompletableFutre on synchronous operation. * Modify `AsyncResponseHandler.handleResponse` method signature * Fix code format Co-authored-by: Marvin Froeder <velo@users.noreply.github.com> Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Refactor AsyncResponseHandler * Extract ResponseHandler from AsyncResponseHandler * Use ResponseHandler on SynchronousMethodHandler Eliminates unnecessary overhead caused by CompletableFutre on synchronous operation. * Modify `AsyncResponseHandler.handleResponse` method signature * Fix code format Co-authored-by: Marvin Froeder <velo@users.noreply.github.com> Co-authored-by: Marvin Froeder <marvin.froeder@dovetailstudios.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Review Guide
It would be good to review changes in commit units instead of PR.