Refactor AsyncFeign #1789
Merged
Refactor AsyncFeign #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
refactor-AsyncFeign
branch
from
13a8ee3 to
73b4017
Compare
|
@velo I pushed the modified commit, but Circle CI doesn't seem to be newly triggered |
velo
approved these changes
Oct 11, 2022
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Refactor to supply defaultContext on ReflectiveFeign * Move target specification verification logic * Refactor TargetSpecificationVerifier Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Refactor to supply defaultContext on ReflectiveFeign * Move target specification verification logic * Refactor TargetSpecificationVerifier Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the integration of AsyncFeign and Feign in mind,
I refactored the AsyncFeign logic in a way that reduces it as much as possible.