updates reactor-core dependency for the feign-reactive-wrappers #1930
Conversation
removed deprecated usage of <code>Schedulers.elastic()</code> and using <code>Schedulers.boundedElastic()</code> instead Fixes OpenFeign#1711
| @@ -30,7 +30,7 @@ public static Builder builder() { | |||
|
|
|||
| public static class Builder extends ReactiveFeign.Builder { | |||
|
|
|||
| private Scheduler scheduler = Schedulers.elastic(); | |||
There was a problem hiding this comment.
Problem is this breaks binary compatibility.... is so annoying when projects break compatibility on minor releases
There was a problem hiding this comment.
can we make Scheduler scheduler a parameter, and if never set, we default to Schedulers.boundedElastic()?
And then document how to use 3.4
There was a problem hiding this comment.
Just for my understanding: Why is it breaking binary compatibility?
It appears to me that the scheduler is already a parameter, which you can set with public Builder scheduleOn(Scheduler scheduler) and Schedulers.elastic() is the current default.
There was a problem hiding this comment.
elastic to boundedElastic breaks anyone using the old version of the library.
Tell you what, as a compromise, move the initialization to constructor and have one that allows user to pick how to create the scheduler and the other defaults to new code
public static Builder builder() {
return new Builder(Schedulers.boundedElastic());
}
public static Builder builder(Scheduler scheduler) {
return new Builder(scheduler);
}
public static class Builder extends ReactiveFeign.Builder {
private Scheduler scheduler;
.. constructor...
nlsbchmnn
force-pushed
the
update_reactor_core_dep
branch
from
c3e0595 to
23918d1
Compare
Created a second builder method which allows to configure the scheduler as a parameter. The default builder method now uses the non deprecated <code>Schedulers.boundedElastic()</code> Fixes OpenFeign#1711
nlsbchmnn
force-pushed
the
update_reactor_core_dep
branch
from
23918d1 to
e1c9145
Compare
* updates reactor-core dependency for the feign-reactive-wrappers removed deprecated usage of <code>Schedulers.elastic()</code> and using <code>Schedulers.boundedElastic()</code> instead Fixes #1711 * moved scheduler initialization to constructor Created a second builder method which allows to configure the scheduler as a parameter. The default builder method now uses the non deprecated <code>Schedulers.boundedElastic()</code> Fixes #1711 --------- Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
* updates reactor-core dependency for the feign-reactive-wrappers removed deprecated usage of <code>Schedulers.elastic()</code> and using <code>Schedulers.boundedElastic()</code> instead Fixes #1711 * moved scheduler initialization to constructor Created a second builder method which allows to configure the scheduler as a parameter. The default builder method now uses the non deprecated <code>Schedulers.boundedElastic()</code> Fixes #1711 --------- Co-authored-by: Marvin Froeder <velo@users.noreply.github.com>
removed deprecated usage of
Schedulers.elastic()and usingSchedulers.boundedElastic()insteadFixes #1711