-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bytecode transformation to reduce code duplication on jakarta modules #2269
Conversation
<skip>true</skip> | ||
<module> | ||
<moduleInfo> | ||
<exports>!jsr311.api; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aalmiray any idea what went wrong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might have been a split package.
5f38129
to
e6facd2
Compare
e6facd2
to
75f9417
Compare
Hey @velo, I don't know if I have missed something, but how am I supposed to use JAXRS3Contract with jakarta? In versions before 13.1 I would use jakarta annotations in my specifications, but after 13.2 when I'm changing from Contract.java (...)
for (final Annotation methodAnnotation : method.getAnnotations()) {
processAnnotationOnMethod(data, methodAnnotation, method); // No annotations found
}
if (data.isIgnored()) {
return data;
}
checkState(data.template().method() != null,
"Method %s not annotated with HTTP method type (ex. GET, POST)%s",
data.configKey(), data.warnings());
(...) I see that the annotation processor fails as my specification uses Is there any documentation that belongs together with this commit that explains how to use jakarta annotations? |
That is odd, how my tests are working?! Anything peculiar about what you are doing? |
Well, kind of. We have a library where we auto builds feign clients for our internal developers. That lib has previously supported both javax and jakarta in that same lib, but now I kan only get one version of jaxrs3 either javax or jakarta. Any suggestions too how we can do that with this implementation? |
…ules (#2269) Co-authored-by: Marvin Froeder <velobr@gmail.com>
…ules (#2269) Co-authored-by: Marvin Froeder <velobr@gmail.com>
No description provided.