-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NullPointerException Bug #2304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, appreciated the effort you put into fixing this problem.
Seems your change includes some git syntax instructions, please fix that.
Also, It looks like nothing what changed on JacksonCodecTest, would you please revert the formatting changes?
Last, but also a blocked, please create a new test case inside RequestTemplateTest.java that reproduced the issue you found.
Thanks for the assistance
@velo Thank you for the kind instructions. |
`RequestTemplate.header(name, values)` method has two overloaded implementations. In the case where `values` has type `Iterable<String>`, `values` is guarded against `null`. This does not happen when `values` has type `String...`, which is fixed by this commit.
All good, you probably did far better than I did on my first one |
I will be releasing feign next Friday, this will be included |
Thank you for the encouraging messages sir!! |
Hey, I'm not going to get more help by being nasty Look forward your next PR |
`RequestTemplate.header(name, values)` method has two overloaded implementations. In the case where `values` has type `Iterable<String>`, `values` is guarded against `null`. This does not happen when `values` has type `String...`, which is fixed by this commit.
`RequestTemplate.header(name, values)` method has two overloaded implementations. In the case where `values` has type `Iterable<String>`, `values` is guarded against `null`. This does not happen when `values` has type `String...`, which is fixed by this commit.
RequestTemplate.header(name, values)
method has two overloaded implementations.In the case where
values
has typeIterable<String>
,values
is guarded againstnull
.This does not happen when
values
has typeString...
, which is fixed by this commit.Concrete testcase:
Result: