Feature/replace deprecated body #959
Conversation
| * @see #charset() | ||
| * @deprecated use {@link #requestBody()} instead | ||
| */ | ||
| public byte[] body() { |
There was a problem hiding this comment.
I don't recall when we deprecated this.
If was on 9.x think is ok to drop it.
There was a problem hiding this comment.
If deprecated method is completely removed from usage, is not that ok to remove the method itself? I think removing it prevents further usage. Should I keep it or remove it?
There was a problem hiding this comment.
A decoder may exists out there that still uses it.
There was a problem hiding this comment.
I see.. Sorry I am not fully familiar on source code. I'll put it back.
Just a question out of this context, is it acceptable to use a 3rd party library (like apache commons lang) for some requirement?
There was a problem hiding this comment.
core has being clean from external dependencies and we are most likely to want to keep it that way.
Particularly about apache commons-*, every time I see them I read "old deprecated code that somehow still survived" =)
kdavisk6
added
chore
|
And one more small housekeeping note, can you please update the description of this PR with the following format: This helps us keep track of what issue the PR is for and provides us with background on your thinking and the intended outcome of this change. |
I updated description. |
|
Thanks for your contribution! |
kdavisk6
removed
the
ready to merge
In this pr the old `body()` method calls replaced with `requestBody().asBytes()` method which both exists in Request class. The intention is to remove deprecated code and keep source code clean. Related to OpenFeign#857 * replaced old body with new Body.asBytes()
In this pr the old `body()` method calls replaced with `requestBody().asBytes()` method which both exists in Request class. The intention is to remove deprecated code and keep source code clean. Related to #857 * replaced old body with new Body.asBytes()
In this pr the old `body()` method calls replaced with `requestBody().asBytes()` method which both exists in Request class. The intention is to remove deprecated code and keep source code clean. Related to #857 * replaced old body with new Body.asBytes()
In this pr the old
body()method calls replaced withrequestBody().asBytes()method which both exists inRequestclass. The intention is to remove deprecated code and keep source code clean.