JacksonEncoder avoids intermediate String request body #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway
schlosna
added a commit
to schlosna/http-remoting
that referenced
this pull request
Jun 18, 2019
Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. Introduces local Jackson encoder until OpenFeign/feign#989 is upstreamed. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway
bulldozer-bot bot
pushed a commit
to palantir/conjure-java-runtime
that referenced
this pull request
Jun 18, 2019
…#1131) Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. Introduces local Jackson encoder until OpenFeign/feign#989 is upstreamed. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway
kdavisk6
added
enhancement
|
Thanks for the review @kdavisk6 . I've updated the PR with your suggestion. |
kdavisk6
approved these changes
Jun 21, 2019
kdavisk6
added
ready to merge
|
I've marked this PR as ready to merge. If there are no additional comments in the next few days, this PR will be merged and is attached to our 10.3.0 Release. |
|
Excellent, thank you! |
velo
approved these changes
Jun 24, 2019
velo
pushed a commit
that referenced
this pull request
Oct 7, 2024
* JacksonEncoder avoids intermediate String request body Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway * Use Util.UTF_8
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
* JacksonEncoder avoids intermediate String request body Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation. See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway * Use Util.UTF_8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize Jackson request object directly to UTF-8 byte array without intermediate String representation.
See https://github.com/FasterXML/jackson-docs/wiki/Presentation:-Jackson-Performance#basics-things-you-should-do-anyway