Custom error class #418
Closed
Custom error class #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Not sure about this one. It feels like a bit of a pointless refactor to be honest. What I was looking for was a re-usable, formally defined and easy to use Error class. I was hoping maybe it would handle the generation of the error message, maybe combining a generic error string with a the mapped message. I was hoping some of this functionality would be unit tested. I think we need to go back to the drawing board on this. Low priority. Let me think about it. |
|
Closing this until I can work out whether it's worth the effort to push this further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add custom request error class
Ref #405
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.