Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toUTF8 function in salesforce #441

Merged
merged 9 commits into from
Dec 1, 2023
Merged

Add toUTF8 function in salesforce #441

merged 9 commits into from
Dec 1, 2023

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Nov 30, 2023

Summary

Add toUTF8 function, This function transliterates unicode characters to their best ASCII representation

Ref #442

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, has the migration tool been run and the
    migration guide followed?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@mtuchi mtuchi changed the title Add toutf8 sf Add toUTF8 function in salesforce Nov 30, 2023
@mtuchi mtuchi requested a review from josephjclark November 30, 2023 13:20
@mtuchi mtuchi marked this pull request as ready for review November 30, 2023 13:20
@josephjclark
Copy link
Collaborator

Thanks @mtuchi - please release from here and then merge down into main!

@mtuchi mtuchi merged commit d3da000 into main Dec 1, 2023
1 check passed
@mtuchi mtuchi deleted the add-toutf8-sf branch December 1, 2023 11:06
mtuchi added a commit that referenced this pull request Jan 24, 2024
* add toUTF8 function

* add changeset

* add unit test

* fix typo

* update ast

* salesforce: fix any-ascii import

* salesforce: fix any-ascii import

* salesforce: add initialiser to not blow up simple-ast

* bump version and update changelog

---------

Co-authored-by: Joe Clark <jclark@openfn.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants