Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GoData Adaptor Email Field Be In Read & Write Mode #450

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

elias-ba
Copy link
Contributor

Summary

Make Godata email field be in read and write mode for Lightning

Details

This PR proposes to update the godata/configuration-schema.json to make the email field in read and write mode for Lightning

Issues

Fixes #1545

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, has the migration tool been run and the
    migration guide followed?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@elias-ba elias-ba changed the title Update Godata/configuration-schema.json to make email field in read and write mode Make GoData Adaptor Email Field Be In Read & Write Mode Dec 13, 2023
@josephjclark
Copy link
Collaborator

@mtuchi can you please release this tomorrow when you have a spare few minutes? Thanks!

@mtuchi
Copy link
Collaborator

mtuchi commented Dec 14, 2023

I have cut a new release [v3.4.0] for this goData adaptor

@mtuchi mtuchi merged commit ceeb029 into main Dec 14, 2023
1 check passed
@mtuchi mtuchi deleted the 1545-godata-email-field branch December 14, 2023 06:30
mtuchi added a commit that referenced this pull request Jan 24, 2024
* Remove writeOnly field and add format field

* Add changeset

* bump version and update changelog

---------

Co-authored-by: Emmanuel Evance <mtuchidev@gmail.com>
mtuchi added a commit that referenced this pull request Mar 19, 2024
* Remove writeOnly field and add format field

* Add changeset

* bump version and update changelog

---------

Co-authored-by: Emmanuel Evance <mtuchidev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email Field Is Rendering As Password For Credential Of Type 'GoData'
3 participants