-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common
Exporting common util
#865
Conversation
afdf650
to
68de3e6
Compare
Alright - the problems here are all do with how our docs generator decides the namespace for a given function. It's a very rigid and limiting system at the moment which just uses the filename and assumes that's it. I'll add a jsdoc extension to give us more control over this |
@mtuchi this should now be working I've tested with this job:
|
And I've added a section to the Wiki for this: https://github.com/OpenFn/adaptors/wiki/Adaptor-Writing-Best-Practice-&-Common-Patterns#namespacing |
Hiya @josephjclark i have tested this PR everything looks good ✅ , Before you merge can you take a look at this PR #888 |
`http` Fix typo in util functions
Summary
Fixes namespacing of util functions in common and exports the utils properly for use by other adaptors.
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy