Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salesforce: move toUTF8 out to utils #896

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

josephjclark
Copy link
Collaborator

Summary

This PR moves to toUTF8 function out into the utils object.

toUTF8 is not an operation and cannot be called at the top level. I am trying to establish a convention where non-operations (regular functions) exist on the util. object. This should make usage clearer across the adaptors.

Fixes #877

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

@josephjclark josephjclark requested a review from mtuchi January 10, 2025 12:59
connection: {},
};

// Run toUTF8 inside an execute block to ensure that any-ascii gets loaded correctly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this comment, i was wondering whey we need execute() for this test

@mtuchi
Copy link
Collaborator

mtuchi commented Jan 10, 2025

Hiya @josephjclark tested the changes everything seems fine, Just a tiny thing i spotted
If you run pnpm i & pnpm build there are changes in ast.json file. Can you double check in your machine if that's a case ?

@josephjclark
Copy link
Collaborator Author

@mtuchi weird - this is probably something on the base branch rather than here 🤔 But I've committed the updated ast - thanks for keeping your eyes open!

@josephjclark josephjclark merged commit da01411 into epic/salesforce Jan 10, 2025
1 check passed
@josephjclark josephjclark deleted the sf-ut8-utils branch January 10, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants