Common util encode should take an object and stringify #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josephjclark please review this for me. |
|
Thank you @PiusKariuki ! I'll look at this tomorrow and hopefully roll it into the same releases as your other fixes (we had a problem with released today which blocked me from getting to release your stuff - should be all OK tomorrow!) |
josephjclark
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks @PiusKariuki! I've got a few suggestions here - please take a look.
When you're done, can you run pnpm changeset and generate a patch change note? Thanks!
…a string empty objects included
…-serializable object
…ed before encoding. This means no errors thrown when numbers, booleans and regex expressions are passed
…an options object that allows users to explicitly disable the JSON parse step
…ode and decode functions i.e. the `parseJson` parameter
|
@josephjclark does this look okay now? |
josephjclark
approved these changes
Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds functionality to encode and decode JSON objects in the encode and decode util functions
Fixes #794
Details
Added a conditional in the
encodeutil to check for objects and stringify them first before encoding them.Added functionality to
decodethat handles JSON objects and parses them to standard JavaScript objects.AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.